feat(devnet-8): show inventory hostnames in the bootnodoor web UI - #67
Open
barnabasbusa wants to merge 1 commit into
Open
feat(devnet-8): show inventory hostnames in the bootnodoor web UI#67barnabasbusa wants to merge 1 commit into
barnabasbusa wants to merge 1 commit into
Conversation
Enables the new bootnodoor_ip_names_enabled toggle so the role uploads the devnet inventory to the bootnodes and bootnodoor displays inventory hostnames instead of bare IPs in its node tables. Requires ethpandaops/ansible-collection-general#578 and a bootnodoor image with ethpandaops/bootnodoor#54.
SummaryEnables bootnodoor_ip_names_enabled for devnet-8 so the bootnodoor web UI shows inventory hostnames instead of bare IPs. The change is a one-line toggle; I confirmed the upstream support it depends on (collection role var + bootnodoor's --ip-names) is absent from both current masters and arrives via git-master tracking, consistent with the author's documented merge order. One deployment-sequencing hazard is worth a look. Issues
Reviewed @ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the new
bootnodoor_ip_names_enabledtoggle for devnet-8's bootnodes. The bootnodoor role uploads the devnet'sinventory.inito each bootnode and passes--ip-namesto the container, so the bootnodoor web UI shows inventory hostnames (e.g.bootnode-1,grandine-besu-2) instead of bare IPs in its node tables — the real IP:port stays available as a hover tooltip.Since bootnodoor re-reads the file on change, re-running the playbook after inventory updates refreshes the names without restarting the container.
Merge order
--ip-names; wait for themasterimage rebuild)Merging this first would fail the bootnodoor container on the unknown
--ip-namesflag.